luci-app-attendedsysupgrade: format error details#8452
Merged
systemcrash merged 1 commit intoopenwrt:masterfrom Mar 23, 2026
Merged
luci-app-attendedsysupgrade: format error details#8452systemcrash merged 1 commit intoopenwrt:masterfrom
systemcrash merged 1 commit intoopenwrt:masterfrom
Conversation
On certain rare errors, the ASU server returns a JSON formatted block of details. The app was just displaying this object directly, resulting in displaying a useless 'Object [object]'. If the error details are not a string, then stringify it so we can make sense of the error. Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
Contributor
|
Merged. Thanks @efahl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain rare errors, the ASU server returns a JSON formatted block of details. The app was just displaying this object directly, resulting in displaying a useless 'Object [object]'. If the error details are not a string, then stringify it so we can make sense of the error.