luci-mod-network: show option also for sae#8454
luci-mod-network: show option also for sae#8454Ramon00 wants to merge 2 commits intoopenwrt:masterfrom
Conversation
For sae the cipher overrule is not exposed. There can be cases where this is needed. See e.g. openwrt/openwrt#22200 Signed-off-by: Ramon Van Gorkom <Ramon00c00@gmail.com>
|
To strengthen my argumentation: Makes no sense that e.g. gcmp-128 cannot be chosen for SAE (where it is part of the standard), but can be chosen for wpa2 (where it is not part of the standard). |
|
Now I have a question. |
|
If you force a setting which is not supported then that will give issues, but that is not unique to sae. E. G. you force WPA to gcmp256 then that will very likely not work(for everybody), but there may be cases where this is needed... |
|
@systemcrash wanne merge this, or shall I close this? |
|
Upon further research I think this PR is safe to merge. 👍 |
Failed checksIssues marked with an ❌ are failing checks. Commit f7eee9f
For more details, see the full job log. Something broken? Consider providing feedback. |
For sae the cipher overrule is not exposed.
There can be cases where this is needed.
See e.g. openwrt/openwrt#22200