Skip to content

luci-mod-network: show option also for sae#8454

Closed
Ramon00 wants to merge 2 commits intoopenwrt:masterfrom
Ramon00:show-for-sae
Closed

luci-mod-network: show option also for sae#8454
Ramon00 wants to merge 2 commits intoopenwrt:masterfrom
Ramon00:show-for-sae

Conversation

@Ramon00
Copy link
Copy Markdown
Contributor

@Ramon00 Ramon00 commented Mar 21, 2026

For sae the cipher overrule is not exposed.
There can be cases where this is needed.
See e.g. openwrt/openwrt#22200

For sae the cipher overrule is not exposed.
There can be cases where this is needed.
See e.g. openwrt/openwrt#22200

Signed-off-by: Ramon Van Gorkom <Ramon00c00@gmail.com>
@Ramon00
Copy link
Copy Markdown
Contributor Author

Ramon00 commented Mar 24, 2026

To strengthen my argumentation: Makes no sense that e.g. gcmp-128 cannot be chosen for SAE (where it is part of the standard), but can be chosen for wpa2 (where it is not part of the standard).

@castiel652
Copy link
Copy Markdown
Contributor

Now I have a question.
Will this cause issue with
openwrt/openwrt@254dd7d
openwrt/openwrt@b48925f

@Ramon00
Copy link
Copy Markdown
Contributor Author

Ramon00 commented Mar 26, 2026

If you force a setting which is not supported then that will give issues, but that is not unique to sae. E. G. you force WPA to gcmp256 then that will very likely not work(for everybody), but there may be cases where this is needed...

@Ramon00
Copy link
Copy Markdown
Contributor Author

Ramon00 commented Mar 30, 2026

@systemcrash wanne merge this, or shall I close this?

@castiel652
Copy link
Copy Markdown
Contributor

Upon further research I think this PR is safe to merge. 👍

@systemcrash
Copy link
Copy Markdown
Contributor

Closed by a4f0c52.

Thanks @Ramon00

@github-actions
Copy link
Copy Markdown

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit f7eee9f

  • ❌ Pull request must not include merge commits

For more details, see the full job log.

Something broken? Consider providing feedback.

@Ramon00 Ramon00 closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants