ddns-scripts: switch to procd handling#28777
Open
feckert wants to merge 1 commit intoopenwrt:masterfrom
Open
Conversation
Contributor
|
Before in 25.12: # apk add ddns-scripts
# uci set ddns.myddns_ipv4.enabled='1'
# uci set ddns.myddns_ipv6.enabled='1'
# uci commit
# apk del ddns-scripts
root@OpenWrt:~# apk add ddns-scripts
(1/4) Installing ddns-scripts-services (2.8.2-r90)
Executing ddns-scripts-services-2.8.2-r90.post-install
(2/4) Installing ip-tiny (6.18.0-r2)
Executing ip-tiny-6.18.0-r2.post-install
* add alternative: /sbin/ip -> /usr/libexec/ip-tiny
(3/4) Installing resolveip (2)
Executing resolveip-2.post-install
(4/4) Installing ddns-scripts (2.8.2-r90)
Installing file to etc/config/ddns.apk-new
Executing ddns-scripts-2.8.2-r90.post-install
85% ############################################# (<<<hangs!) If you ctrl+c now, it leaves artifacts. You can continue the installation with /etc/init.d/ddns stop. With this PR: Now it installs nicely. And "/etc/init.d/ddns stop" does kill all sessions, including those that were disabled after the service has started. I didn't notice anything broken, both in a x86_64 VM and in a BpiR3. Thanks. Tested-by: Luiz Angelo Daros de Luca luizluca@gmail.com |
The 'ddns-scripts' still uses not the procd service handling. This commit changes this. Signed-off-by: Florian Eckert <fe@dev.tdt.de> Tested-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
feckert
force-pushed
the
pr/20260313-ddns-scripts
branch
from
29f8598 to
4149110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the ddns-scripts handling to use procd service.
📦 Package Details
Maintainer: me
Description:
The 'ddns-scripts' still uses not the procd service handling. This commit changes this.
In the LuCI, the dynamic_dns_updater is still being called via the helper function. This also needs to be refactored before merge. Otherwise, LuCI will stop working.
Should Fixes: #28722
🧪 Run Testing Details
✅ Formalities