mailsend: cherry-pick fix ssl variant to use opensssl#28868
Open
danielfdickinson wants to merge 1 commit intoopenwrt:openwrt-25.12from
Open
mailsend: cherry-pick fix ssl variant to use opensssl#28868danielfdickinson wants to merge 1 commit intoopenwrt:openwrt-25.12from
danielfdickinson wants to merge 1 commit intoopenwrt:openwrt-25.12from
Conversation
As described in openwrt#28261 Not compiled with OpenSSL, the SSL variant of the mailsend package is not actually being compiled with OpenSSL. This is due to an upstream configure check borrowed from an ancient version of BIND, which no longer works. As a workaround we add `-DHAVE_OPENSSL=1` to the `TARGET_CFLAGS` when building the SSL variant. This results in a complaint about COPTS not being honoured correctly, but results in `mailsend` compiled with OpenSSL (i.e. works). Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca> (cherry picked from commit 444b62c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @thess
Description:
As described in #28261 Not compiled with OpenSSL, the SSL variant of the mailsend package is not actually being compiled with OpenSSL.
This is due to an upstream configure check borrowed from an ancient version of BIND, which no longer works.
As a workaround we add
-DHAVE_OPENSSL=1to theTARGET_CFLAGSwhen building the SSL variant.This results in a complaint about COPTS not being honoured correctly, but results in
mailsendcompiled with OpenSSL (i.e. works).(cherry picked from commit 444b62c)
Closes #28695
🧪 Run Testing Details
TODO: but already tested in master
✅ Formalities