Fix stale DB redirects appearing as new assessments in quality logs#1107
Fix stale DB redirects appearing as new assessments in quality logs#1107arnchlmcodes wants to merge 7 commits intoopenzim:mainfrom
Conversation
ba03457 to
81f4b9b
Compare
|
I love it! 4 years old challenge fixed by a two lines patch! |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 92.78% 92.73% -0.05%
==========================================
Files 74 74
Lines 4308 4310 +2
==========================================
Hits 3997 3997
- Misses 311 313 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
audiodude
left a comment
There was a problem hiding this comment.
Shouldn't you just add a comparison between page_touched and timestamp_dt to the SQL query itself? Why try to compare after the row has already been retrieved?
|
@audiodude Changed the approach to check the condition within the SQL query itself, Please take a look and lmk |
page_touched was being parsed into timestamp_dt directly, overwriting the project's last run cutoff before any comparison could be made. Now it Stores the parsed value in row_timestamp_dt and return None if not newer than last run
Fixes #462