Fix: stop AdditionalPropertiesKeyword from throwing incorrect errors #148

[BasilLangevin]

This commit prevents Opis\JsonSchema\Keywords\AdditionalPropertiesKeyword from throwing incorrect errors when the data is invalid.

To prevent erroneous invalidation, it checks the properties that have been defined in the current schema and removes them from the unchecked properties array.

This commit resolves #148

[sorinsarca]

This is a quick fix but it doesn't handle patternProperties.
I whould not add logic for patternProperties inside additionalProperties keyword,
the logic must be inside patternProperties and properties; so in the end additionalProperties remains unchanged.
It is a little tricky, but it can be done.

[BasilLangevin]

Thank you for the guidance.

I checked out both files (PatternPropertiesKeyword and PropertiesKeyword), and the issue appears to be that PropertiesKeyword had an early return before $context->addCheckedProperties(...) when it encountered an error.

After moving addCheckedProperties up before the early return, the test suite continues to pass, and the issue with #148 is resolved.

I haven't been able to reproduce this issue using "patternProperties" - properties defined with a pattern don't seem to be incorrectly invalidated by the AdditionalPropertiesKeyword either before or after this latest fix. As such, I haven't modified the PatternPropertiesKeyword file. However, that file's validate method also returns early upon encountering an error (without first adding the checked properties context), so if there is an error with "patternProperties" validation, the solution may be the same.

[andreaswolf]

I can confirm that this does the trick when specifying additiionalProperties: false together with setStopAtFirstError(false). We need this to be able to show a comprehensive list of errors while editing a file, so only showing the first error is not really an option in our case.

Any chance of getting this merged and released? I fixed it in our installation via a Composer patch, but that's not ideal.

[takayuki-serato]

Any updates on this @sorinsarca @BasilLangevin ? We are keen to use this library but it is quite confusing when this bug crops up

[CaptainQuirk]

Hi !

The issue is a huge hindrance on adopting your library.

It would be great if it would go forward !

Thansk in advance