Conversation
There was a problem hiding this comment.
Hello @Jose-Sabater,
Thank you for submitting this large pull request for the opper-node SDK regeneration and feature addition! I've performed a thorough review of the generated code and the surrounding package structure.
The implementation of the new methods, specifically submitFeedback (in src/sdk/spans.ts) and uploadFile (in src/sdk/knowledge.ts), appears technically correct and adheres to the expected Speakeasy generation patterns.
However, I found two critical issues related to package management and user documentation that require changes before this PR can be merged. I am requesting changes based on these findings:
| Focus Area | Status | Details |
|---|---|---|
| Correctness (New Features) | ✅ Pass | submitFeedback and uploadFile functions are correctly implemented in the generated code. |
| Versioning | ❌ Blocked | The package.json version remains at 3.4.0 (same as main). Major feature additions (new endpoints) require a minor or major version bump (e.g., to 3.5.0 or 4.0.0) according to semantic versioning guidelines. |
| Documentation | ❌ Blocked | The primary usage guide (README.md) contains no mention, usage examples, or API reference for the new submitFeedback and uploadFile methods. This prevents users from discovering and utilizing the new features. |
Requested Changes:
- Update
package.json: Increment the version number (e.g., to3.5.0or higher) to reflect the new API methods added. - Update
README.md: Add clear, runnable code examples and documentation for using the newclient.spans.submitFeedback(...)andclient.knowledge.uploadFile(...)methods in the main usage guide.
Please address these points. Once fixed, I will be happy to re-review and approve.
— agentobot[bot]
No description provided.