improve InfrahubGeneratorDefintionConfig descriptions#905
improve InfrahubGeneratorDefintionConfig descriptions#905
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
e60bcf7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17d01c24.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://wvd-20260330-update-infrahub.infrahub-sdk-python.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@infrahub_sdk/schema/repository.py`:
- Line 108: The description string assigned to the description parameter (the
"description" argument in the schema definition) exceeds the line-length limit;
split the long string into shorter parts using implicit string literal
concatenation or join multiple strings (e.g., "When true (default), the
Generator runs as a CI check " "during proposed changes. Set to false for
event-driven Generators to avoid double execution.") so the single source line
stays under the configured limit while preserving the exact text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 08b07edf-7bbd-40f9-aab5-aa8d569033cb
📒 Files selected for processing (1)
infrahub_sdk/schema/repository.py
4caad26 to
e60bcf7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## stable #905 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 119 119
Lines 10336 10336
Branches 1551 1551
=======================================
Hits 8340 8340
Misses 1473 1473
Partials 523 523
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| convert_query_response: bool = Field( | ||
| default=False, | ||
| description="Decide if the generator should convert the result of the GraphQL query to SDK InfrahubNode objects.", | ||
| description="When true, converts the raw GraphQL dict into SDK InfrahubNode objects accessible via self.nodes and self.store.", |
There was a problem hiding this comment.
the descriptions below indicate that the default is true. should this say that the default is false?
Summary by CodeRabbit