Show changes to profiles within diff view for PC and branch#8676
Show changes to profiles within diff view for PC and branch#8676
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe data-diff view was changed to include Profile entries by removing "Profile" from namespace exclusion filters in data-tab, branches/details, and proposed-changes/details. The node-diff header now uses 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6d9c817 to
507aac1
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/app/src/entities/proposed-changes/ui/tabs/data-tab.tsx`:
- Line 16: Add regression tests that verify profile-namespace items are shown
and counted in the Data diff: render the DataTab component (DataTab) with a
proposedChanges payload that includes entries under the "profile" namespace (and
ensure Schema entries remain excluded), then assert the profile items are
present in the rendered list and that the Data tab label/count reflects those
items; add one test for list rendering and one for tab count behavior (render
the parent tabs or the component/function that computes tab counts) using the
existing testing-library/Jest patterns so the new inclusion of profile is locked
by tests.
In `@frontend/packages/schema-visualizer`:
- Line 1: The commit added a gitlink for the submodule
frontend/packages/schema-visualizer but did not register it in .gitmodules; add
a [submodule "frontend/packages/schema-visualizer"] entry to .gitmodules
including path = frontend/packages/schema-visualizer and the repository URL for
that submodule (matching the origin used to create the gitlink), then commit the
updated .gitmodules so Git can initialize/update the submodule at commit
8496f057a14c041bcc4ce7a91af2b77a8bd2f17e.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3f4de3f7-0e4d-44b9-8844-351b6cb94f21
📒 Files selected for processing (6)
changelog/8529.fixed.mdfrontend/app/src/entities/diff/node-diff/node.tsxfrontend/app/src/entities/proposed-changes/ui/tabs/data-tab.tsxfrontend/app/src/pages/branches/details.tsxfrontend/app/src/pages/proposed-changes/details.tsxfrontend/packages/schema-visualizer
…ub into pog-profile-diff-IFC-2316
Why
Ensure that changes to profiles show up within the data diff view for proposed changes and profiles
Fixes #8529
What changed
Previously we excluded the Schema and Profile namespace. It makes sense to remove the Schemas from the the data view but we want the Profiles to show up.
Example of screenshot
Summary by CodeRabbit