Ensure Spec-Kitty dashboard is correctly launched each time#8680
Ensure Spec-Kitty dashboard is correctly launched each time#8680
Conversation
WalkthroughThe changes update the dashboard specification documentation. Previously, the workflow validated work-package directory existence before conditionally launching the browser dashboard. The new workflow unconditionally kills existing dashboard instances and immediately starts a fresh one. The startup procedure now uses 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
dev/commands/kitty-spec.dashboard.md (1)
33-34: Consider consistency in script invocation and potential startup failure handling.Two observations:
Inconsistency: Line 33 invokes
dashboard.py --killwhile line 34 callsserver.pydirectly. Line 20 also usesdashboard.pyfor consistency. While both approaches work (dashboard.py is a thin wrapper forwarding to server.py), usingdashboard.pyconsistently would improve maintainability.Error suppression risk: Line 33 suppresses stderr with
2>/dev/null. If the kill operation fails and a dashboard instance remains running, the new dashboard on line 34 may fail to start due to a port conflict (default port 5050). Consider whether startup failures should be surfaced to the user or if the documentation should note this edge case.♻️ Proposed change for consistency
- python dev/spec-kitty/kittify/scripts/dashboard.py --kill 2>/dev/null - nohup python dev/spec-kitty/kittify/scripts/dashboard/server.py --feature <branch-name> > /dev/null 2>&1 & + python dev/spec-kitty/kittify/scripts/dashboard.py --kill 2>/dev/null + nohup python dev/spec-kitty/kittify/scripts/dashboard.py --feature <branch-name> > /dev/null 2>&1 &🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@dev/commands/kitty-spec.dashboard.md` around lines 33 - 34, Use dashboard.py consistently (replace the direct server.py invocation with the dashboard.py wrapper) and remove or limit blind stderr suppression so startup errors are visible; specifically, change the nohup invocation that currently runs server.py to call dev/spec-kitty/kittify/scripts/dashboard.py --feature <branch-name> and avoid redirecting stderr to /dev/null (or add a note about port 5050 conflicts) so failures like port-in-use from an unsuccessful --kill are surfaced to the user.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@dev/commands/kitty-spec.dashboard.md`:
- Around line 33-34: Use dashboard.py consistently (replace the direct server.py
invocation with the dashboard.py wrapper) and remove or limit blind stderr
suppression so startup errors are visible; specifically, change the nohup
invocation that currently runs server.py to call
dev/spec-kitty/kittify/scripts/dashboard.py --feature <branch-name> and avoid
redirecting stderr to /dev/null (or add a note about port 5050 conflicts) so
failures like port-in-use from an unsuccessful --kill are surfaced to the user.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3df5070a-8d17-4c09-930d-6320a62aca61
📒 Files selected for processing (1)
dev/commands/kitty-spec.dashboard.md
Summary by CodeRabbit
Release Notes
Test plan
/kitty-spec.dashboardwith existing work packages — dashboard should launch and terminal summary should display/kitty-spec.dashboardwith no work packages — dashboard should still launch, terminal should note no WPs exist/kitty-spec.dashboardwhen a dashboard is already running — old instance should be killed before launching new one🤖 Generated with Claude Code