Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughCI workflows and the frontend Docker build stage were changed to use Node.js 24 instead of 22. Package engine constraints were added or bumped to 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@changelog/`+node24-migration.housekeeping.md:
- Line 1: The file ending containing the line "Migrated Node.js from version 22
to 24 LTS across CI workflows, Docker build, and package engine constraints." is
missing a trailing newline; fix by editing that markdown file and ensure there
is a single newline character at EOF (i.e., add a blank line after the existing
text) so the file ends with a trailing newline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 11e20fef-7673-4c11-9c11-cf176b6f3504
📒 Files selected for processing (8)
.github/workflows/ci.ymlchangelog/+node24-migration.housekeeping.mddevelopment/Dockerfiledocs/docs/development/frontend/getting-set-up.mdxdocs/docs/snippets/pre-reqs-frontend.mdxdocs/package.jsonfrontend/app/package.jsonfrontend/packages/ui/package.json
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/chromatic.yml (1)
37-37: Use deterministic CI installs (npm ci) instead ofnpm install.The current
npm installon line 37 can yield non-reproducible dependency resolution across runs. Usenpm cifor stable, deterministic Chromatic builds sincepackage-lock.jsonis present.Proposed update
- name: Install Node.js uses: actions/setup-node@v6 with: node-version: 24 + cache: npm + cache-dependency-path: frontend/packages/ui/package-lock.json - name: Install dependencies - run: npm install + run: npm ci🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/chromatic.yml at line 37, Replace the workflow step that currently executes "run: npm install" with a deterministic install by using "npm ci" instead; update the Chromatic workflow entry that contains the "run: npm install" command so it runs "npm ci" (ensuring package-lock.json is committed) to achieve reproducible CI installs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/chromatic.yml:
- Line 37: Replace the workflow step that currently executes "run: npm install"
with a deterministic install by using "npm ci" instead; update the Chromatic
workflow entry that contains the "run: npm install" command so it runs "npm ci"
(ensuring package-lock.json is committed) to achieve reproducible CI installs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9b3ca597-f530-4579-bc03-66c2e50a2eda
📒 Files selected for processing (1)
.github/workflows/chromatic.yml
Merging this PR will degrade performance by 27.96%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_get_schema |
250.1 ms | 327.7 ms | -23.67% |
| ❌ | test_get_menu |
188.4 ms | 245.4 ms | -23.24% |
| ❌ | test_schemabranch_process |
793.8 ms | 1,040.9 ms | -23.74% |
| ❌ | test_schemabranch_duplicate |
5.5 ms | 7.2 ms | -23.75% |
| ❌ | test_graphql_generate_schema |
372.5 ms | 517 ms | -27.96% |
| ❌ | test_nodemanager_querypeers |
1.3 ms | 1.5 ms | -17.62% |
| ❌ | test_relationshipmanager_getpeer |
132 µs | 160.4 µs | -17.66% |
| ❌ | test_query_one_model |
354.1 ms | 464.3 ms | -23.74% |
| ❌ | test_query_rel_many |
524.2 ms | 692.1 ms | -24.25% |
| ❌ | test_base_schema_duplicate_CoreProposedChange |
1.7 ms | 2.1 ms | -18.62% |
| ❌ | test_query_rel_one |
501.8 ms | 662.8 ms | -24.29% |
| ❌ | test_load_node_to_db_node_schema |
51.6 ms | 66.4 ms | -22.24% |
Comparing bab-node-24 (579e8c8) with stable (33332fc)1
Footnotes
|
The failure in the CI should be fixed after a rebase. Having said that perhaps we want this to go into |
fatih-acar
left a comment
There was a problem hiding this comment.
I believe it's safe to this upgrade in stable directly but would like you to confirm
Also need this change in the enterprise repo.
Summary by CodeRabbit
Chores
Documentation