Replace with onechart#2
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the Makefile to streamline Helm packaging, downgrades chart versions to 0.79.0, and renames the 'onechart' chart to 'onechart-cnpg'. Review feedback indicates that the rename is a breaking change and has caused inconsistencies in the documentation. Several OCI repository references in the README and documentation still point to the old name and require updates to ensure the provided examples work correctly.
| @@ -1,5 +1,5 @@ | |||
| apiVersion: v2 | |||
| name: onechart | |||
| name: onechart-cnpg | |||
There was a problem hiding this comment.
The chart name has been changed from onechart to onechart-cnpg. This appears to contradict the pull request title "Replace with onechart" and is a breaking change for existing users. If this rename is intentional (e.g., to distinguish this version with CloudNativePG support), please ensure the documentation and OCI references are updated to match.
| You can also template and install onechart from an OCI repository as follows: | ||
|
|
||
| > **Note:** The examples use version `0.80.0`. This will be the unreleased version if you are at the `main` branch. | ||
| > **Note:** The examples use version `0.79.0`. This will be the unreleased version if you are at the `main` branch. |
There was a problem hiding this comment.
Since the chart has been renamed to onechart-cnpg, this note should be updated to avoid confusion.
| > **Note:** The examples use version `0.79.0`. This will be the unreleased version if you are at the `main` branch. | |
| > **Note:** The examples use version `0.79.0`. This will be the unreleased version of `onechart-cnpg` if you are at the `main` branch. |
|
|
||
| ```bash | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.80.0 \ | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ |
There was a problem hiding this comment.
The OCI repository URL should be updated to reflect the new chart name onechart-cnpg. Using the old name will likely result in a "not found" error when attempting to pull version 0.79.0.
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ | |
| helm template my-release oci://ghcr.io/opsta/onechart-cnpg --version 0.79.0 \ |
|
|
||
| ```bash | ||
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.80.0 \ | ||
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ |
There was a problem hiding this comment.
The OCI repository URL should be updated to reflect the new chart name onechart-cnpg.
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ | |
| helm install my-release oci://ghcr.io/opsta/onechart-cnpg --version 0.79.0 \ |
|
|
||
| ```bash | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.80.0 -f values.yaml | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 -f values.yaml |
There was a problem hiding this comment.
The OCI repository URL should be updated to reflect the new chart name onechart-cnpg.
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 -f values.yaml | |
| helm template my-release oci://ghcr.io/opsta/onechart-cnpg --version 0.79.0 -f values.yaml |
|
|
||
| ```bash | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.80.0 \ | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ |
There was a problem hiding this comment.
The OCI repository URL should be updated to reflect the new chart name onechart-cnpg.
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ | |
| helm template my-release oci://ghcr.io/opsta/onechart-cnpg --version 0.79.0 \ |
|
|
||
| ```bash | ||
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.80.0 \ | ||
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ |
There was a problem hiding this comment.
The OCI repository URL should be updated to reflect the new chart name onechart-cnpg.
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ | |
| helm install my-release oci://ghcr.io/opsta/onechart-cnpg --version 0.79.0 \ |
|
|
||
| ```bash | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.80.0 -f values.yaml | ||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 -f values.yaml |
There was a problem hiding this comment.
The OCI repository URL should be updated to reflect the new chart name onechart-cnpg.
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 -f values.yaml | |
| helm template my-release oci://ghcr.io/opsta/onechart-cnpg --version 0.79.0 -f values.yaml |
1 participant
No description provided.