fix: convert _try_get_single_vector_source to iterative traversal#80
Merged
fix: convert _try_get_single_vector_source to iterative traversal#80
Conversation
Convert recursive tree traversal to iterative using explicit stack. This prevents RecursionError on deep expression trees (40,000+ nodes). Additional improvements: - Handle VectorPowerSum and VectorUnarySum - Handle VectorExpressionSum (new from PR #78) - Handle UnaryOp expressions - Handle Parameter nodes Completes Task 4 of v1.2.3 roadmap. Closes #72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert
_try_get_single_vector_sourcefrom recursive to iterative traversal using an explicit stack. This preventsRecursionErroron deep expression trees (40,000+ nodes).Changes
VectorPowerSumandVectorUnarySumVectorExpressionSum(new from PR feat: add VectorExpressionSum for O(1) VectorExpression.sum() #78)UnaryOpexpressionsParameternodesTesting
v1.2.3 Roadmap
This completes Task 4 - the final item in the v1.2.3 roadmap.
Closes #72