ci: add pre-commit workflow#137
Closed
peter-svensson wants to merge 4 commits into
Closed
Conversation
Run .pre-commit-config.yaml hooks on PRs (formatting, linters, gitleaks, go-fumpt, golangci-lint). Aligns with other opzkit modules.
3 tasks
TekWizely/pre-commit-golang hooks invoke goimports, gofumpt and golangci-lint as system binaries. Install them before running pre-commit so go-imports, go-fumpt and golangci-lint-mod hooks pass.
- Makefile + pre-commit workflow: golangci-lint v1.62.2 -> v2.12.2 (.golangci.yml uses v2 schema; v1 silently ignored excludes, causing G201/SA1019/ifElseChain to fire in CI) - Pin gofumpt v0.10.0 and goimports v0.44.0 in workflow - gofumpt fixes in internal/database/postgres.go, internal/controller/database_controller.go and test/integration/operator_test.go - Refactor 3 if/else chains to switch in database_controller.go for clarity (now redundant since gocritic ifElseChain is excluded, but the switch form is cleaner regardless)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/pre-commit.yamlto run hooks from.pre-commit-config.yamlon PRssetup-go(usesgo.modversion) since hooks include go-mod-tidy, go-fumpt, golangci-lintTest plan
pre-commitruns and passes (or fails on real issues)