Two minor fixes#148
Merged
Merged
Conversation
The code that gets certs from keyrings currently only gets RSA certs, so we need to zero out the PQ certs length fields when a keyring is used. Otherwise the retrieval callback will look in the wrong offset in the tlshd_certs list. Reported-by: Sagi Grimberg <sagi@grimberg.me> Fixes: facd084 ("tlshd: Client-side dual certificate support") Fixes: 14f5349 ("tlshd: Server-side dual certificate support") Signed-off-by: Scott Mayhew <smayhew@redhat.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
GitHub Actions has deprecated Node.js 20. Recent CI runs emit the runner warning that actions/checkout@v4 will be forced to Node.js 24 on 2026-06-02 and that Node.js 20 will be removed from runners on 2026-09-16. The cache, configure-pages, upload-pages-artifact, and deploy-pages pins still reference Node 20 release lines and would draw the same warning when the documentation workflow next runs. Move every pinned third-party action to its current Node 24 release. The checkout pin matches the v6.0.2 SHA already used by macaron-check-github-actions.yml, keeping the repository consistent. Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.