Respect the 'forceITMSync' option in orbzmq/orbdump#170
Open
lunakiller wants to merge 1 commit intoorbcode:mainfrom
Open
Respect the 'forceITMSync' option in orbzmq/orbdump#170lunakiller wants to merge 1 commit intoorbcode:mainfrom
lunakiller wants to merge 1 commit intoorbcode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 9761c75 removed TPIU-related functions from the code, but also removed ITM Decoder initialization in
orbzmqandorbdump. The ITM decoder is not initialized properly usingITMDecoderInit(), which means that theforceITMSyncparameter is completely ignored. As a result,orbzmqandorbdumpdo not work without ITM sync packets, while the rest of the tools work without sync packets as expected.This PR fixes the issue and both
orbzmqandorbdumprespect the--itm-syncoption.