Skip to content

ALCHEMI-Toolkit wrapper for Orb#167

Open
vsimkus wants to merge 4 commits into
mainfrom
nvalchemi-wrapper
Open

ALCHEMI-Toolkit wrapper for Orb#167
vsimkus wants to merge 4 commits into
mainfrom
nvalchemi-wrapper

Conversation

@vsimkus

@vsimkus vsimkus commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds OrbWrapper, a nvalchemi-toolkit integration that lets Orb models plug into nvalchemi dynamics engines (FIRE, MD, etc.) and pipeline composition (e.g. Orb + DFT-D3; conservative-models only)
  • Adds README examples

Known issue

Stress tensors from non-equivariant models may be asymmetric due to a non-symmetrized displacement in nvalchemi.models._utils.prepare_strain(). This bug is captured by the failing tests. This is an upstream nvalchemi bug - we should wait for the fix to land there before merging this PR.

vsimkus commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@socket-security

socket-security Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpypi/​nvalchemi-toolkit@​0.1.098100100100100

View full report

@vsimkus vsimkus force-pushed the nvalchemi-wrapper branch from 48c04a6 to 9b5b7cd Compare June 6, 2026 16:27
@socket-security

socket-security Bot commented Jun 6, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: pypi loguru is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: ?pypi/nvalchemi-toolkit@0.1.0pypi/loguru@0.7.3

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore pypi/loguru@0.7.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@vsimkus vsimkus changed the title Added nvalchemi wrapper ALCHEMI-Toolkit wrapper for Orb Jun 6, 2026
@vsimkus vsimkus marked this pull request as ready for review June 6, 2026 19:40
@vsimkus vsimkus force-pushed the nvalchemi-wrapper branch from dfccfb0 to b266bad Compare June 7, 2026 18:13

@benrhodes26 benrhodes26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌿

@vsimkus vsimkus changed the base branch from port-from-internal-052026 to graphite-base/167 June 9, 2026 17:33
@vsimkus vsimkus force-pushed the nvalchemi-wrapper branch from b266bad to c4160db Compare June 9, 2026 17:34
@vsimkus vsimkus force-pushed the graphite-base/167 branch from ad6adf3 to 81b26ac Compare June 9, 2026 17:34
@vsimkus vsimkus changed the base branch from graphite-base/167 to main June 9, 2026 17:34
@timduignan

Copy link
Copy Markdown
Contributor

I think I've found an issue, opening a PR internally for review/discussion so can we hold of on merging until thats resolved thanks.

@timduignan

Copy link
Copy Markdown
Contributor

Ok nevermind I think the problem was elsewhere sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants