fix(workflow): validate graph after policy injection#4162
Open
nporter-codes wants to merge 4 commits into
Open
fix(workflow): validate graph after policy injection#4162nporter-codes wants to merge 4 commits into
nporter-codes wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue — Closes #4153
Root-cause analysis
The
WorkflowManager.execute_workflow()method directly iterated and executed workflow steps without any validation. If a workflow had duplicate step IDs, non-callable handlers, circular step references, or no steps at all, execution would proceed without error checking — leading to confusing failures midway through the workflow lifecycle. The issue specifically noted that "automatic guard nodes" were not enforced.Fix
WorkflowManager.validate_workflow()method that checks:execute_workflow()to callvalidate_workflow()before starting executionFAILEDand errors are stored in_last_errorsAcceptance criteria
Files changed
src/orchestrator/workflow.py— validate_workflow(), execute_workflow() gateTest output