fix(metrics): handle exporter counter range limits#4166
Open
nporter-codes wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue — Closes #4096
Root-cause analysis
The
MetricsCollector.increment()method performed unchecked integer addition. Pythonintis unbounded, but downstream metrics backends (Prometheus, OpenTelemetry, etc.) commonly have 64-bit integer limits. A counter that exceeded2^53(the JavaScript-safe integer limit and a common backend boundary) would cause the downstream system to reject or silently corrupt the metric value.Fix
DEFAULT_MAX_COUNTER = 2**53as the default safe limitMetricsCollector.__init__()accepts an optionalmax_counterparameter (configurable per-instance)increment()now checks if the new value would exceedmax_counterand raisesValueErrorbefore modifying stateAcceptance criteria
Files changed
src/common/metrics.py— max counter validationTest output