attempt to split up datasets by NAN value so different colors can be applied#496
Draft
MoralCode wants to merge 1 commit intoorf:masterfrom
Draft
attempt to split up datasets by NAN value so different colors can be applied#496MoralCode wants to merge 1 commit intoorf:masterfrom
MoralCode wants to merge 1 commit intoorf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is some work i started for #409
i tried several different approaches and keep running into an issue where rust complains about returning owned values.
i dont know if there are ways around that but i wanted to put my code here in case someone more knowledgeable can see what im doing wrong
the general approach im going for take the same approach as https://github.com/MoralCode/TUI-coolors-demo (splitting the datasets up to apply different colors to each of them) since it seems like styling information is applied to an entire dataset at once.