Draft Feature: Histogram of Response Time#530
Draft
isosphere wants to merge 6 commits intoorf:masterfrom
Draft
Conversation
Contributor
Author
|
I've added a toggle via a keypress of The currently inefficient binning code is only active when the histogram is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current screenshot: (will update as I push changes)
This draft PR is open for feedback.
I think the histogram gives a nice sense of the distribution of ping times in a way a time series plot doesn't. I'm pretty happy with how this is working for myself.
Shortcomings as of this writing:
I think the last item should be fixed before this is merged, it's fairly long-hanging fruit.
Footnotes
CPU: it recalculates the bin counts from scratch every time a sample is added ↩
Memory: it collects its own sample cache, which is redundant and possibly misleading, as
DEFAULT_WINDOW_SIZEneed not correspond with the time series chart extent at all. ↩