MVP: Ability to specify a file to write to.#98
Open
hbina wants to merge 4 commits intoorf:masterfrom
hbina:allow_outfile
Open
MVP: Ability to specify a file to write to.#98hbina wants to merge 4 commits intoorf:masterfrom hbina:allow_outfile
hbina wants to merge 4 commits intoorf:masterfrom
hbina:allow_outfile
Conversation
Now logs the pongs in a buffer. Next is to use some kinda resize-able ring buffer of sort to put the pongs in and have a consumer thread. Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>
For the moment it will not clear out its buffer when we exit the program. Will do that in the future. Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>
1. Only hold the lock as necessary. 2. Returns immediately from polling for input. Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>
Draw shouldn't lock now. Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes with a lot of code changes. It is becoming quite unwieldy, maybe consider a refactoring? Like I think the key parsing thing is perfect, I don't want to keep seeing it.
TODO:
HashMapis better thanVechere because we keep trying to access this from different threads. But I am just guessing here.