fix: resolve E2E test failures on Node 22+ (import attributes, port conflicts, server readiness)#746
Open
pedrotainha wants to merge 4 commits intooriginjs:mainfrom
Open
fix: resolve E2E test failures on Node 22+ (import attributes, port conflicts, server readiness)#746pedrotainha wants to merge 4 commits intooriginjs:mainfrom
pedrotainha wants to merge 4 commits intooriginjs:mainfrom
Conversation
Move webpack-host from ports 5000/5001 to 5010/5011 so it does not collide with other examples that also bind to 5000. Add a portMap lookup in vitestSetup-serve.ts and vitestSetup-dev.ts so the test harness navigates to the correct host port per example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #745
Summary
import ... assertwithimport ... within 6 rollup config files across examples (Node 22+ removed theassertkeyword)EADDRINUSEwhen tests run sequentially:webpack-host: 5010/5011simple-react-systemjs: 5020/5021basic-host-remote: 5030/5031simple-react-webpack: 5040/5041waitForServer()poll invitestSetup-serve.tsandvitestSetup-dev.tsto avoid race condition between server startup andpage.goto()beforeAllhook timeout from 60s to 120s to accommodate slow builds + server readiness waithtml-webpack-plugindependency tosimple-react-webpack/remoteTest plan
pnpm test:e2e-serve— 11 passed, 0 failed, 1 skipped (was 6 passed, 5 failed)pnpm test:unit— 46 passed (no regressions)withis supported from Node 18.20+)Files changed
Import assertions → attributes (6 files):
packages/examples/simple-react-systemjs/{host-systemjs,remote-systemjs}/rollup.config.mjspackages/examples/basic-host-remote/rollup-host/rollup.config.mjspackages/examples/simple-react-webpack/host/rollup.config.mjspackages/examples/simple-react-esm/{host-esm,remote-esm}/rollup.config.mjsPort reassignment + portMap (18 files):
packages/examples/webpack-host/(5 files)packages/examples/simple-react-systemjs/(5 files)packages/examples/basic-host-remote/(5 files)packages/examples/simple-react-webpack/(6 files)Server readiness + timeout (2 files):
packages/examples/vitestSetup-serve.tspackages/examples/vitestSetup-dev.tsMissing dependency (1 file + lockfile):
packages/examples/simple-react-webpack/remote/package.jsonpnpm-lock.yaml