Conversation
Added use of schema in foreign keys, Many to Many Added field to schema conversion via sqlalchemy
formating file
| @@ -0,0 +1 @@ | |||
| DATABASE_URL=postgresql://pguser:pgpassword@localhost:10011/postgres No newline at end of file | |||
There was a problem hiding this comment.
Definitely do not commit a .env file.
If you need to rely on a .env file, create a template (e.g., .env.example) and add .env into the gitignore.
It would also require some form of documentation in the README to explain the purpose of this.
There was a problem hiding this comment.
Thanks for the note, I didn’t notice that the original project did not have a preset ignoring env files
There was a problem hiding this comment.
For me personally, this functionality is necessary to build a system built for data analysis in a company. I have many different users who have their own schemes with their own rights. I would like to give them access only to their schemas, without generating configs for each of them
I also saw the issues in discussions about schema support, but no one promoted it
…om/hk3dva/ormar into feature_add_schema_to_ormar_config
Merging this PR will degrade performance by 28.35%
Performance Changes
Comparing |
|
Hi, looks promising but I'm missing some more query-related tests -> there is quite a complicated table and column prefixing happening under the hood to prevent colliding on the same names between tables and columns. That's why we need to test some joins -> like select related, prefetch related, same table joins, multiple joins to the same table, accessing relationships and reverse relationships from models, and some filtering. Between the tables in different schemas as same table schema is covered, probably also some joins to the 2 tables with same name but in different schemas. I know that it's most common use case is separation and not combining data in different schemas, but with proper permissions, that is a perfectly valid use case, so we need to make sure it works as expected. |
…om/hk3dva/ormar into feature_add_schema_to_ormar_config
Added use of schema in foreign keys, Many to Many
Added field to schema conversion via sqlalchemy