Forward autoincrement property from field to column#674
Open
smuething wants to merge 6 commits intoormar-orm:masterfrom
Open
Forward autoincrement property from field to column#674smuething wants to merge 6 commits intoormar-orm:masterfrom
smuething wants to merge 6 commits intoormar-orm:masterfrom
Conversation
The autoincrement property of ormar fields did not get propagated to the SQLAlchemy column definition. As a result, the autoincrement property of the SQLAlchemy column defaulted to `auto`, making it impossible to create DDL that did not auto-increment the database column.
…utoincrement_columns
CodSpeed Performance ReportMerging #674 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autoincrement property of ormar fields does not get propagated to the SQLAlchemy column definition. As a result, the autoincrement property of the SQLAlchemy column defaults to
auto, making it impossible to create DDL that does not auto-increment the database column.With this small patch, it becomes possible to create a table with a manually managed, integer-based PK.