Skip to content

allow fk field filtering python style#854

Draft
Abdeldjalil-H wants to merge 11 commits intoormar-orm:masterfrom
Abdeldjalil-H:master
Draft

allow fk field filtering python style#854
Abdeldjalil-H wants to merge 11 commits intoormar-orm:masterfrom
Abdeldjalil-H:master

Conversation

@Abdeldjalil-H
Copy link
Contributor

I have edited the FieldAccessor._check_field method to allow foreign keys filtering in python style. More details about this in #846

@Abdeldjalil-H Abdeldjalil-H marked this pull request as draft September 30, 2022 07:11
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (52d992d) to head (bd6b7fe).
Report is 1 commits behind head on master.

❗ Current head bd6b7fe differs from pull request most recent head d9f74d9. Consider uploading reports for the commit d9f74d9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #854     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          203       188     -15     
  Lines        14791     16833   +2042     
===========================================
+ Hits         14791     16833   +2042     
Files Coverage Δ
ormar/queryset/field_accessor.py 100.00% <100.00%> (ø)
tests/test_model_definition/test_fields_access.py 100.00% <100.00%> (ø)

... and 181 files with indirect coverage changes

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 23, 2024

CodSpeed Performance Report

Merging #854 will degrade performances by 13.74%

Comparing Abdeldjalil-H:master (d9f74d9) with master (5f4354d)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 81 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master Abdeldjalil-H:master Change
test_max[1000] 15.6 ms 13.7 ms +13.26%
test_exists[250] 11.9 ms 13.8 ms -13.74%
test_get_or_none[1000] 14.1 ms 12.3 ms +14.56%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants