refactor(test): consolidate split test methods#226
Merged
Conversation
Contributor
|
Thank you for contributing to this project! 😊🕹️ |
Merge split test methods into single table-driven methods following the one-suite-method-per-function convention: - metrics_test: 3 InitMeter methods → TestInitMeter - telemetry_test: 3 InitTracer methods → TestInitTracer - slog_public_test: merge PreservesTraceID into TestNewTraceHandler - target_public_test: merge CacheHit into TestValidTarget Also remove two obsolete backlog tasks superseded by the osapi-orchestrator (sdk-response-types, declarative-playbook). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
retr0h
force-pushed
the
refactor/consolidate-test-methods
branch
from
87bc806 to
379252f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 161 161
Lines 5611 5611
=======================================
Hits 5552 5552
Misses 50 50
Partials 9 9 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
just go::unit— all tests passjust go::vet— 0 lint issues🤖 Generated with Claude Code