AO3-5100 List all Open Challenges with pagination and filtering#5721
Open
ayasayadi1 wants to merge 8 commits intootwcode:masterfrom
Open
AO3-5100 List all Open Challenges with pagination and filtering#5721ayasayadi1 wants to merge 8 commits intootwcode:masterfrom
ayasayadi1 wants to merge 8 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5100
Purpose
Merge Gift Exchange and Prompt Meme lists
list_challengesruns two separate queries (one for Gift Exchanges and one for Prompt Memes), concatenates and caps the results at 15. It now runs a single query across both challenge types, paginated and sorted by closing date.Include challenges with no closing date
The open challenges query filters by
signups_close_at > now, which silently excludes challenges with no closing date. The filter now matches challenges closing in the future or challenges with no closing date set.Filter Open Challenges
Open Challenges can now be filtered by title, tag, multifandom, closed, moderated, and collection type (the "No Challenge" option is hidden since it's all challenges)
Gift Exchange Challenges and Prompt Meme Challenges support the same filters, except collection type.
Credit
Aya Sayadi