Skip to content

AO3-7316 Change blockquote element in admin banners to be div instead #5722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wAO3rker wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

AO3-7316 Change blockquote element in admin banners to be div instead #5722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf8a47f
Change banner wrapper from blockquote to div
wAO3rker Apr 11, 2026
743a53f
Changed banner wrapper from blockquote to div
wAO3rker Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/admin/banners/_banner.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<% # expects admin_banner %>
<% # don't forget to update layouts/banner! %>
<div class="<%= admin_banner.banner_type %> announcement group">
<blockquote class="userstuff">
<div class="userstuff">
<%= raw sanitize_field(admin_banner, :content, image_safety_mode: true) %>
</blockquote>
</div>
</div>
4 changes: 2 additions & 2 deletions app/views/layouts/_banner.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<% if @admin_banner&.active? %>
<% unless session[:hide_banner] || current_user&.preference&.banner_seen %>
<div class="<%= @admin_banner.banner_type %> announcement group" id="admin-banner">
<blockquote class="userstuff">
<div class="userstuff">
<%= raw sanitize_field(@admin_banner, :content, image_safety_mode: true) %>
</blockquote>
</div>
<% if current_user.nil? %>
<p class="submit">
<%= link_to current_path_with(hide_banner: true), "aria-label": t(".hide"), class: "showme action" do
Expand Down
Loading