SkinPartition: compare Bones lists by content, not reference#23
Merged
ousnius merged 2 commits intoousnius:mainfrom Apr 25, 2026
Merged
Conversation
`skinPart.Partitions[i].Bones != skinPart.Partitions[i - 1].Bones` compared the List<ushort> references. Two partitions with identical bone palettes held in separate lists always compared "different", which set PF_START_NET_BONESET on every subsequent partition — wasteful boneset restarts during render. Matches C++ nifly NifFile.cpp:4458 where the same expression uses std::vector<uint16_t>::operator!= (element-by-element comparison). Use SequenceEqual for the C# equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdatePartitionFlagschecksPartitions[i].Bones != Partitions[i-1].Bonesto decide whether to emit a "start net boneset" flag. In C#!=onList<>is reference equality, so two partitions that happen to share contents but are distinct list instances will always be flagged as different — the flag becomes meaningless.C++ reference:
nifly/NifFile.cpp:4458— comparison usesstd::vector<uint16_t>::operator!=, which is element-wise.Fix: use
!SequenceEqual(...)for the C# equivalent.Maps to issue #15 item B6.