Build ICU with ClangCL so -march actually limits codegen#174
Merged
dylan-conway merged 2 commits intomainfrom Mar 10, 2026
Merged
Build ICU with ClangCL so -march actually limits codegen#174dylan-conway merged 2 commits intomainfrom
dylan-conway merged 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughModifies the build script to introduce ClangCL-compatible architecture flags for stage 2 builds, adds a new toolset argument configuration, and extends vcxproj patching logic to strip resource definitions and prevent rc.exe involvement during compilation. Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Preview Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC
/arch:SSE2is a no-op on x64 and the auto-vectorizer emits AVX2/AVX512 regardless, so switch the stage 2 static rebuild to ClangCL and use/clang:-march=like we do for WebKit proper.