test: adjust WedDav preview test case for Devanagari script [full-ci]#41672
Conversation
This acceptance test case use Devenagari script as an example of a non-Latin script. It confirms that a preview of a text file containing Devanagari script can be produced in PNG format. The preview used in the test scenario has been made bigger (64x64). That makes the graphic resolution good enough that I can manually recognise the characters rendered in the resulting PNG image, and confirm that they are a good rendering of the text. Note: depending on the installed environment, some Devanagari ligatures may not be rendered correctly. That also applies for other scripts. If an installation wants to accurately support rendering of a wide range of scripts, then they need to organise to have suitable additional libraries installed that will support those scripts. The purpose of this test scenario is not to ensure that all scripts work correctly. The purpose is just to ensure that some combination of non-Latin characters can be correctly processed, stored as a preview, and the binary content of the preview is correctly returned to the user that called the API.
|
https://github.com/owncloud/core/actions/runs/28933473781/job/85840164502?pr=41672 Scenario passed, good. |
dj4oC
left a comment
There was a problem hiding this comment.
Re-enables the previously @skipped WebDAV preview acceptance scenario for non-Latin (Devanagari) content, swapping the sample text/fixture to मेरो पानी and bumping the preview to 64×64 so the rendered glyphs are verifiable.
Branch target
oC11 / master — ok.
Findings
- Security: no findings — Gherkin text + binary fixture swap only; no production code, no injection/traversal/credential surface.
- Stability: no findings — removing
@skipre-enables the scenario in the normal pipeline (the intent of #41480); no PHP 8.3 / backward-compat impact. Independently confirmed theapiWebdavPreviewsacceptance shard passed on this HEAD (job 85840164502, success) — the un-skipped scenario actually runs green, not merely claimed. - Performance: no findings — N/A for a test-only change.
- Test coverage: net increase — this restores previously-disabled coverage. The ≥85% gate is N/A here since no production code is touched. No changelog required is correct (repo convention for tests-only; changelog-lint is green).
- All 45 CI checks green.
- Minor / non-blocking: removing the
@issue-41480 @skipline leaves a double blank line before theScenario:— cosmetic, consistent with the file's blank-line separation style; no change needed.
Verdict
Commenting — clean, low-risk, tests-only change that re-enables verified-green coverage. No blocking issues; good to merge once a human maintainer signs off.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
🤖 Automated review by Claude Code (security · stability · performance · coverage) Generated by Claude Code |
This acceptance test case use Devenagari script as an example of a non-Latin script. It confirms that a preview of a text file containing Devanagari script can be produced in PNG format.
The preview used in the test scenario has been made bigger (64x64). That makes the graphic resolution good enough that I can manually recognise the characters rendered in the resulting PNG image, and confirm that they are a good rendering of the text.
Note: depending on the installed environment, some Devanagari ligatures may not be rendered correctly. That also applies for other scripts. If an installation wants to accurately support rendering of a wide range of scripts, then they need to organise to have suitable additional libraries installed that will support those scripts. The purpose of this test scenario is not to ensure that all scripts work correctly. The purpose is just to ensure that some combination of non-Latin characters can be correctly processed, stored as a preview, and the binary content of the preview is correctly returned to the user that called the API.
Fixes #41480
Tests only, no changelog required.
Running full-ci so that the modified acceptance test will run in CI of this PR.