fix(deps): resolve 9 Dependabot alerts in js/#545
Merged
Conversation
All alerts are transitive dev-scope deps, remediated via npm `overrides` in js/package.json. Verified: `npm install` clean, `gulp` build green, karma/jasmine suite 22/22 passing (postcss 7->8 and merge 1->2 are major bumps — build and tests confirmed unaffected). - js-yaml 3.14.2 -> 3.15.0 (#71, GHSA quadratic-complexity DoS, needs >= 3.15.0) - lodash 4.17.23 -> 4.18.1 (#62 code injection via _.template, #63 prototype pollution in _.unset/_.omit, needs >= 4.18.0) - merge 1.2.1 -> 2.1.1 (#14 prototype pollution, needs >= 2.1.1; major bump) - minimatch 3.0.4/3.1.2 -> 3.1.5 (#54 ReDoS in matchOne(), needs >= 3.1.3) - minimist (under optimist) 0.0.10 -> 0.2.4 (#30 critical + #9 prototype pollution, needs >= 0.2.4; per-parent override, root minimist already 1.2.8) - postcss 7.0.39 -> 8.5.16 (#66 XSS via unescaped </style>, #35 line-return parsing, needs >= 8.5.10; major bump, no 7.x patch exists) Note: `npm audit` still reports separate issues (brace-expansion, es5-ext, micromatch, socket.io-parser, ws) that are NOT in the Dependabot alert set; out of scope for this change. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Member
Author
|
CI note: the JS Unit check failed on the first run with |
phil-davis
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 9 open Dependabot alerts. Every alert is a transitive, dev-scope dependency in
js/package-lock.json; all are remediated via a singleoverridesblock injs/package.json.Fixed
_.template; prototype pollution in_.unset/_.omitmatchOne()optimist > minimistoverride; rootminimistwas already 1.2.8 and untouched</style>; line-return parsing (major bump — no 7.x patch exists)Test plan
npm install— clean, resolutions confirmed at/above each threshold.npm run build(gulp lint + build + uglify) — ✅ green.npm test(karma + jasmine, headless Chrome) — ✅ 22/22 passing.The postcss 7→8 and merge 1→2 major bumps were the primary risk; build and tests confirm no breakage. Verified locally on Node v18.
Out of scope
npm auditreports 5 further issues (brace-expansion, es5-ext, micromatch, socket.io-parser, ws) that are not in the current Dependabot alert set and are not addressed here.