feat(idm): add --service-user flag to resetpassword command#12118
Merged
mmattel merged 4 commits intoowncloud:masterfrom Apr 17, 2026
Merged
feat(idm): add --service-user flag to resetpassword command#12118mmattel merged 4 commits intoowncloud:masterfrom
mmattel merged 4 commits intoowncloud:masterfrom
Conversation
|
mklos-kw
reviewed
Mar 16, 2026
Member
|
@kobergj Any security reasons why not to add this change? |
paul43210
force-pushed
the
fix/idm-resetpw-service-users
branch
from
2a336c7 to
d4a4f83
Compare
mmattel
force-pushed
the
fix/idm-resetpw-service-users
branch
from
d4a4f83 to
f50e233
Compare
paul43210
force-pushed
the
fix/idm-resetpw-service-users
branch
from
f50e233 to
00fa9a4
Compare
kobergj
approved these changes
Apr 14, 2026
The DN was hardcoded to ou=users, making it impossible to reset passwords for service accounts (libregraph, idp, reva) which live under ou=sysusers. The new --service-user flag selects the correct OU. Fixes: owncloud#12106 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paul Faure <paul@faure.ca>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paul Faure <paul@faure.ca>
auto-merge was automatically disabled
April 15, 2026 18:28
Head branch was pushed to by a user without write access
paul43210
force-pushed
the
fix/idm-resetpw-service-users
branch
from
2a619f1 to
468f2ac
Compare
Replace the --service-user boolean flag with a --user-type string flag that accepts 'user' (default) or 'service'. This is more extensible if additional user types are added in the future. Addresses review feedback from mklos-kw. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paul Faure <paul@faure.ca>
Contributor
Author
|
Thanks for the approval @kobergj! And good suggestion @mklos-kw — replaced the Validates that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--service-userflag toocis idm resetpasswordso it can target service accounts (ou=sysusers) instead of only regular users (ou=users)ou=users, making it impossible to reset passwords forlibregraph,idp, orrevaservice users via the CLIUsage
Test plan
ocis idm resetpassword -u adminstill works (targetsou=users)ocis idm resetpassword -u reva --service-usertargetsou=sysusersFixes: #12106
🤖 Generated with Claude Code