Skip to content

Fix TEST_FIXTURES_DIR path in test_helper.bash#2

Merged
p3ob7o merged 1 commit into
claude/review-assistant-requirements-Pxq4ffrom
copilot/sub-pr-1
Feb 1, 2026
Merged

Fix TEST_FIXTURES_DIR path in test_helper.bash#2
p3ob7o merged 1 commit into
claude/review-assistant-requirements-Pxq4ffrom
copilot/sub-pr-1

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 1, 2026

The TEST_FIXTURES_DIR variable was resolving to a non-existent top-level fixtures/ directory, causing T01.7 test to fail when looking for test-vault-populated.

Changes:

  • Updated TEST_FIXTURES_DIR path in tests/helpers/test_helper.bash from ${BATS_TEST_DIRNAME}/../fixtures to ${BATS_TEST_DIRNAME}/fixtures

Since BATS_TEST_DIRNAME points to tests/ (the directory containing the .bats file), the corrected path now properly resolves to tests/fixtures/ where the test fixtures are actually located.

# Before: resolves to fixtures/ (non-existent)
export TEST_FIXTURES_DIR="${BATS_TEST_DIRNAME}/../fixtures"

# After: resolves to tests/fixtures/ (correct)
export TEST_FIXTURES_DIR="${BATS_TEST_DIRNAME}/fixtures"

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update T01 vault structure tests based on feedback Fix TEST_FIXTURES_DIR path in test_helper.bash Feb 1, 2026
Copilot AI requested a review from p3ob7o February 1, 2026 17:13
@p3ob7o p3ob7o marked this pull request as ready for review February 1, 2026 17:17
@p3ob7o p3ob7o merged commit fb6d5ed into claude/review-assistant-requirements-Pxq4f Feb 1, 2026
1 check passed
@p3ob7o p3ob7o deleted the copilot/sub-pr-1 branch February 1, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants