Switch to the Atlassian Jira Cloud instance and API#390
Switch to the Atlassian Jira Cloud instance and API#390TomasTomecek merged 1 commit intopackit:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the Jira-related functionality from Jira Data Center to Jira Cloud, addressing several key changes. The authentication mechanism has been updated from Bearer to Basic Auth, and the Jira search endpoint has been switched to the v3 API. Additionally, the Jira dev-status API is now used instead of the BitBucket API for fetching development status. The changes are well-distributed across the codebase, including constants, utility functions, fetchers, and tools, and the test suite has been updated accordingly. Overall, this is a significant and necessary update to ensure compatibility with the new Jira Cloud instance.
TomasTomecek
left a comment
TomasTomecek
left a comment
There was a problem hiding this comment.
this is straightforward, thank you, very nice work!
| # Get the dev-status summary first to discover valid applicationType values | ||
| summary_url = urljoin( | ||
| jira_base, | ||
| f"rest/dev-status/1.0/issue/summary?issueId={issue_id}", |
There was a problem hiding this comment.
great to see there is a replacement
| data: | ||
| JIRA_URL: https://issues.redhat.com/ | ||
| JIRA_URL: https://redhat.atlassian.net/ | ||
| JIRA_EMAIL: jotnar@redhat.com |
There was a problem hiding this comment.
thanks for updating the openshift configs as well
|
@TomasTomecek the latest push is only for supervisor/jira_utils.py which fixes some Jira Cloud restrictions that Martin has found in his supervisor related testing. |
|
Merging, fetcher and triage agent worked just fine for me locally. Thank you very much for addressing this so promptly. |
2 participants
As we have recently migrated to Jira Cloud from Jira Data Center this set of changes is needed to make Jira related functionality to work. Originally i wanted to keep both working (this being open source project and all) however it is not feasible for me to do so due to the old Data Center instance no longer fully functioning to do any testing and just the time constraints associated.
The major changes are:
This has been tested for Jira issue fetcher, Triage and Backport agents, specifically that they can search and retrieve issues, add and remove labels, add comments etc. I have not done any real life testing for Supervisor except a few curl tests, we're currently not using it so it is hard for me to verify it on anything real.