Skip to content

Fix issue #412: enable controlling packit-service with the command#3068

Open
JackDKobe wants to merge 1 commit intopackit:mainfrom
JackDKobe:fix-issue-412
Open

Fix issue #412: enable controlling packit-service with the command#3068
JackDKobe wants to merge 1 commit intopackit:mainfrom
JackDKobe:fix-issue-412

Conversation

@JackDKobe
Copy link

Fixes good-first-issue #412

@JackDKobe JackDKobe requested a review from a team as a code owner March 22, 2026 00:14
@JackDKobe JackDKobe requested review from lbarcziova and removed request for a team March 22, 2026 00:14
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a change to README.md by adding an HTML comment, seemingly to trigger automation. While I understand this might be for enabling a new feature, embedding cryptic, invisible commands in documentation files is detrimental to maintainability. My feedback suggests removing this change and using a more conventional method for automation triggers, like PR comments or labels.

Comment on lines +18 to +20


<!-- fix-issue-412: enable controlling packit-service with the command embedded -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change adds an invisible HTML comment and extra blank lines to the README.md file. This seems to be for automation, but embedding commands this way harms maintainability, as the purpose is unclear and it adds clutter to a core documentation file. It's preferable to trigger automation via more standard mechanisms like PR comments or labels. I recommend removing these lines.

@centosinfra-prod-github-app
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants