Fix issue #412: enable controlling packit-service with the command#3068
Fix issue #412: enable controlling packit-service with the command#3068JackDKobe wants to merge 1 commit intopackit:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a change to README.md by adding an HTML comment, seemingly to trigger automation. While I understand this might be for enabling a new feature, embedding cryptic, invisible commands in documentation files is detrimental to maintainability. My feedback suggests removing this change and using a more conventional method for automation triggers, like PR comments or labels.
|
|
||
|
|
||
| <!-- fix-issue-412: enable controlling packit-service with the command embedded --> |
There was a problem hiding this comment.
This change adds an invisible HTML comment and extra blank lines to the README.md file. This seems to be for automation, but embedding commands this way harms maintainability, as the purpose is unclear and it adds clutter to a core documentation file. It's preferable to trigger automation via more standard mechanisms like PR comments or labels. I recommend removing these lines.
|
❌ pre-commit FAILURE in 1m 59s |
Fixes good-first-issue #412