Trigger LD for the correct buildArch taskID#3071
Trigger LD for the correct buildArch taskID#3071centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of triggering LogDetective with the parent Koji task ID instead of the correct child buildArch task IDs. The changes are consistent across the event definition, parser, handler, and helper, and the logic for iterating over failed subtasks is sound. The tests have also been updated appropriately to cover the new functionality. I have one suggestion for a minor refactoring to improve efficiency.
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
3 times, most recently
from
a4ae17e to
1c68f10
Compare
|
❌ pre-commit FAILURE in 1m 50s |
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
from
1c68f10 to
4a52feb
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 52s |
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
the changes overall look good, just few notes. Besides the code here, could you verify the reporting via commit status will work when processing the results from Log Detective? (i.e. there will be no status name collision)
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
from
4a52feb to
557cfc9
Compare
|
✔️ pre-commit SUCCESS in 2m 04s |
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
from
557cfc9 to
e84704f
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 48s |
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
from
e84704f to
bd27c18
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 49s |
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
from
bd27c18 to
15854fc
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
2 times, most recently
from
ed3bc12 to
854c42d
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 52s |
|
The derivation of URL will be solved by #3075 |
- instead of the parent build target task - also streamlined the CI reporting Signed-off-by: Jan Matufka <jmatufka@redhat.com>
Jany26
force-pushed
the
ld-koji-fix-task-ids-urls
branch
from
854c42d to
cb7d8e2
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 47s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 49s |
4 participants
Instead of the parent task ID, we now pass the failed buildArch child task IDs.
This should prevent 404 errors when accessing logs at
https://kojipkgs.fedoraproject.org/work/tasks/YYYY/XXXXYYYY/build.log.Additionally, the CI reports are now consistent with other tasks, they include deployment and target-arch / chroot information.
TODO:
rpm_build_task_statesdictionary for arch -> task state lookuprpm_build_task_idsandrpm_build_task_states)Fixes #3067
Related to #2971
RELEASE NOTES BEGIN
Packit now triggers LogDetective with the correct artifact URLs for failed downstream Koji scratch builds.
LogDetective CI jobs are now properly reported.
RELEASE NOTES END