Add commit hash to video window title#93
Open
xnetcat wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the emulator’s VideoOut window title to include the build’s Git commit hash, making it easier to identify exactly which build is running when testing or collecting logs.
Changes:
- Extend
VideoOutExports.ConfigureApplicationInfoto accept an emulator commit SHA and incorporate it into the window title. - Pass
BuildInfo.CommitShafrom the runtime when configuring VideoOut application info.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SharpEmu.Libs/VideoOut/VideoOutExports.cs | Adds commit SHA support and appends it to the VideoOut window title formatting. |
| src/SharpEmu.Core/Runtime/SharpEmuRuntime.cs | Supplies BuildInfo.CommitSha to VideoOut so the title can display the build hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private static long _flipSubmitCount; | ||
|
|
||
| public static void ConfigureApplicationInfo(string? title, string? titleId, string? version) | ||
| public static void ConfigureApplicationInfo(string? title, string? titleId, string? version, string? emulatorCommitSha) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the emulator build commit hash in the video window title.