Conversation
davxy
reviewed
Jun 1, 2026
Comment on lines
+40
to
+44
| println!( | ||
| "Chunking deg {} polynomial into {} chunks", | ||
| q_deg, | ||
| q_chunks.len() | ||
| ); |
Member
There was a problem hiding this comment.
Suggested change
| println!( | |
| "Chunking deg {} polynomial into {} chunks", | |
| q_deg, | |
| q_chunks.len() | |
| ); |
| use ark_poly::Evaluations; | ||
| use ark_poly::Polynomial; | ||
| use ark_serialize::{CanonicalDeserialize, CanonicalSerialize}; | ||
| use ark_std::vec::Vec; |
Member
There was a problem hiding this comment.
Suggested change
| use ark_std::vec::Vec; | |
| use ark_std::{vec, vec::Vec}; |
| @@ -0,0 +1,39 @@ | |||
| use ark_ff::{Field, PrimeField}; | |||
| use ark_poly::univariate::DensePolynomial; | |||
| use ark_poly::DenseUVPolynomial; | |||
Member
There was a problem hiding this comment.
Suggested change
| use ark_poly::DenseUVPolynomial; | |
| use ark_poly::DenseUVPolynomial; | |
| use ark_std::vec::Vec; |
davxy
reviewed
Jun 1, 2026
| let mut bfs = Vec::with_capacity(witness.len() * n_polys); | ||
| // per tree level | ||
| let n_columns = P::VerifierCircuit::N_COLUMNS; | ||
| let n_to_commit = n_columns + 4; // plus the quotient chunks |
Member
There was a problem hiding this comment.
IIUC 4 is the number of chunks the commitment quotient is split into for Pasta.
Nit: what about defining a global constant instead of a magic number?
something like: pub const MAX_QUOTIENT_CHUNKS = 4 in the pasta-tree/src/lib.rs?
For what concerns KZG commitment, we stick to 1 chunk, correct?
I.e. we're using the ProverPiop::quotient() default implementation. If so, AFAICT the proof remains backward compat?
davxy
reviewed
Jun 1, 2026
Comment on lines
+281
to
+300
| // let (log_n, h) = (9, 2); | ||
| // println!("n = {}, height = {h}, TALL", 1 << log_n); | ||
| // _test_proof::< | ||
| // ark_pallas::Projective, | ||
| // ark_vesta::Projective, | ||
| // CircuitParamsTall<ark_vesta::Affine>, | ||
| // CircuitParamsTall<ark_pallas::Affine>, | ||
| // >(log_n, h); | ||
| // println!(); | ||
|
|
||
| // let (log_n, h) = (10, 2); | ||
| // println!("n = {}, height = {h}, TALL", 1 << log_n); | ||
| // _test_proof::< | ||
| // ark_pallas::Projective, | ||
| // ark_vesta::Projective, | ||
| // CircuitParamsTall<ark_vesta::Affine>, | ||
| // CircuitParamsTall<ark_pallas::Affine>, | ||
| // >(log_n, h); | ||
| // println!(); | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| // let (log_n, h) = (9, 2); | |
| // println!("n = {}, height = {h}, TALL", 1 << log_n); | |
| // _test_proof::< | |
| // ark_pallas::Projective, | |
| // ark_vesta::Projective, | |
| // CircuitParamsTall<ark_vesta::Affine>, | |
| // CircuitParamsTall<ark_pallas::Affine>, | |
| // >(log_n, h); | |
| // println!(); | |
| // let (log_n, h) = (10, 2); | |
| // println!("n = {}, height = {h}, TALL", 1 << log_n); | |
| // _test_proof::< | |
| // ark_pallas::Projective, | |
| // ark_vesta::Projective, | |
| // CircuitParamsTall<ark_vesta::Affine>, | |
| // CircuitParamsTall<ark_pallas::Affine>, | |
| // >(log_n, h); | |
| // println!(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.