Conversation
Updates the organization type select to use the `items` prop at the root level as documented by Shadcn/Base-UI. This ensures the selected label is correctly mapped and displayed in the trigger. Also memoizes the `orgTypes` collection for stability.
- Creates `LoginPage` POM at `e2e/pages/LoginPage.ts`. - Migrates login tests to `e2e/features/auth/login.spec.ts`. - Adds automated scenarios for success and common failure paths. - Removes legacy test file.
- Move redirects.spec.ts to features/auth directory - Create PendingPage and RejectedPage Page Object Models - Update LoginPage POM with Google sign-in button locator - Add deep-link redirection tests for restricted account statuses - Refactor existing tests to use the new POMs for better robustness
- Created Organization-specific Page Object Models (POMs) - Refactored e2e feature tests to use the new POMs - Reorganized e2e/pages directory by domain (org/ and auth/) - Updated import paths in all feature tests across both domains - All 22 tests (13 org, 9 auth) passing after restructuring
- **Auth Redirects**: Split restricted users test into independent `pending` and `rejected` test blocks to prevent playwright context isolation race conditions. - **Org Join**: Substituted hardcoded `TEST_JOIN_ID` with dynamically generated `v7()` UUIDs to avoid unique constaint violations in the database when workers run concurrently. - **Unit ordering**: Modified `UnitRepository.findByOrganizationId` to incorporate secondary ordering by `createdAt` to guarantee absolute deterministic ordering for UI list verification in tests. Added DOM visibility checks to unit additions in `OrgDetailPage.ts` to solve hydration wait races.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
domus-cron | 454c416 | Commit Preview URL Branch Preview URL |
Apr 07 2026, 04:49 AM |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 46.05% 45.98% -0.07%
==========================================
Files 74 74
Lines 2191 2194 +3
Branches 458 457 -1
==========================================
Hits 1009 1009
- Misses 1182 1185 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.