update: ingestion=true/false in home api#1531
Conversation
WalkthroughAdds an Changes
Sequence Diagram(s)(No sequence diagrams generated for this change.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/prism/home/mod.rs`:
- Around line 154-156: Change the computation of data_ingested so it uses the
server-wide streams collection instead of the RBAC-/internal-filtered datasets:
replace the current use of datasets.iter().any(|d| d.ingestion) with a check
against all_streams (or the variable holding server-wide streams) e.g.
all_streams.iter().any(|s| s.ingestion), and ensure the Checklist struct's
data_ingested field is set from that server-wide boolean rather than the
filtered datasets value.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/prism/home/mod.rs`:
- Line 237: The ingestion detection uses stream_jsons.iter().all(|s|
s.first_event_at.is_some()) which returns false if any metadata lacks
first_event_at; change this to use any() so ingested becomes true when any
stream_json has data: replace the call to .all(...) with .any(...) on
stream_jsons (keep the same closure checking s.first_event_at.is_some()) so the
ingested variable correctly reflects "stream has any data" semantics.
Summary by CodeRabbit
Improvements
Breaking Changes
✏️ Tip: You can customize this high-level summary in your review settings.