Skip to content

fix: ingestion restriction#1533

Merged
nitisht merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:ingestion-improvements
Feb 3, 2026
Merged

fix: ingestion restriction#1533
nitisht merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:ingestion-improvements

Conversation

@nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Feb 3, 2026

if stream log source is already set to otel-logs,
do not allow non otel json ingestion

Summary by CodeRabbit

  • Refactor
    • Updated stream ingestion validation to account for log source types when processing OpenTelemetry logs, metrics, and traces, with enhanced compatibility checks during ingestion.

if stream log source is already set to otel-logs,
do not allow non otel json ingestion
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Walkthrough

The ingestion validation system is enhanced to consider log sources during stream validation. The validate_stream_for_ingestion function now accepts a log_source parameter, enabling validation of log source compatibility and enforcing OtelLogs-specific ingestion rules across ingest and post_event paths.

Changes

Cohort / File(s) Summary
Validation Function Enhancement
src/handlers/http/ingest.rs, src/handlers/http/modal/utils/ingest_utils.rs
Function signature updated to accept log_source: &LogSource parameter. Call sites in ingest() and post_event() updated to pass log source. Implementation now validates log source compatibility, enforcing that stream entries don't have incompatible formats (non-OtelTraces/OtelMetrics) and ensuring OtelLogs streams only accept OtelLogs ingestion.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • restrict otel ingestion #1263: Both PRs modify ingestion validation and log-source compatibility logic, with this PR updating the validation function signature to accept log_source and enforce OtelLogs rules.

Suggested labels

for next release

Suggested reviewers

  • nitisht

Poem

🐰 A rabbit's rhyme for validation's grace,
Log sources now find their rightful place,
OtelLogs dance in compatibility's embrace,
Stream validation runs a safer race, 🌟

🚥 Pre-merge checks | ❌ 3
❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required template sections like detailed goals, rationale, key changes, and testing/documentation checklist items. Fill out the complete PR template with sections for goals, solution rationale, key changes, and mark the testing/documentation checklist items to document what was done.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fix: ingestion restriction' is vague and does not clearly describe what restriction is being fixed or why. It lacks specificity about the log source validation change. Consider a more descriptive title such as 'fix: enforce otel-logs validation for stream ingestion' or 'fix: prevent non-otel ingestion to otel-logs streams' to clarify the specific change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitisht nitisht merged commit 368656b into parseablehq:main Feb 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants