This repository was archived by the owner on Dec 1, 2025. It is now read-only.
Spec: Aggregate error reporting#172
Merged
Merged
Conversation
Adds support for aggregate error reporting. Additional changes are required to the embedding APIs' specs to support the feature.
Collaborator
Author
|
@dmcardle, could you PTAL? Thanks! |
dmcardle
reviewed
Feb 25, 2025
Contributor
dmcardle
left a comment
dmcardle
left a comment
There was a problem hiding this comment.
Thanks, Alex! Just made one pass through and left some questions and nits.
alexmturner
commented
Feb 25, 2025
Collaborator
Author
alexmturner
left a comment
alexmturner
left a comment
There was a problem hiding this comment.
Thanks, Dan!
dmcardle
approved these changes
Feb 26, 2025
Contributor
dmcardle
left a comment
dmcardle
left a comment
There was a problem hiding this comment.
Regardless of my last round of comments, this LGTM at this point :)
Collaborator
Author
|
Uhh not sure why my recent replies aren't both showing up on this thread, but here they are: |
Contributor
Gah! Another one for the gripe list! I noticed this a couple days ago, too. |
Collaborator
Author
Collaborator
Author
|
Great, thanks for reviewing! |
github-actions Bot
added a commit
that referenced
this pull request
Mar 3, 2025
SHA: e5804a7 Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alexmturner
added a commit
to WICG/shared-storage
that referenced
this pull request
Mar 7, 2025
Adds support for the new Private Aggregation error reporting feature to Shared Storage. See the related PAA spec change: patcg-individual-drafts/private-aggregation-api#172 Also see the explainer: https://github.com/patcg-individual-drafts/private-aggregation-api/blob/main/error_reporting.md Slightly reorganizes the PAA integration with this spec for readability.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 10, 2025
Replaces usage of "non-internal" to "external" to better match the spec: patcg-individual-drafts/private-aggregation-api#172 Bug: 381788013 Change-Id: If139ff27eb74f6467adf2649c7bc9b0ccb7aefd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335576 Reviewed-by: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Alex Turner <alexmt@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1430543}
alexmturner
added a commit
to WICG/shared-storage
that referenced
this pull request
Mar 19, 2025
Adds support for the new Private Aggregation error reporting feature to Shared Storage. See the related PAA spec change: patcg-individual-drafts/private-aggregation-api#172 Also see the explainer: https://github.com/patcg-individual-drafts/private-aggregation-api/blob/main/error_reporting.md Slightly reorganizes the PAA integration with this spec for readability.
Collaborator
Author
|
Note that spec PRs for integrating with Shared Storage and Protected Audience can be found here: |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 28, 2025
Adds support for the kPrivateAggregationApiErrorReporting feature*, including the new flow involving two calls to the interface: first, `InspectBudgetAndLock()`; and then, `ConsumeBudget()`. The old flow (when the feature is disabled) is also maintained for now. When the feature is disabled (which it is by default), this cl should have no effect. These new calls are also not yet integrated with the manager; this will be done in a follow-up cl. *This feature is described further here: https://github.com/patcg-individual-drafts/private-aggregation-api/blob/main/error_reporting.md It was specified here: patcg-individual-drafts/private-aggregation-api#172 Bug: 381788013 Change-Id: Iccd452826b887e1de39a33ab5344de2de6774978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304832 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Dan McArdle <dmcardle@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1439738}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for aggregate error reporting. Additional changes are required to the embedding APIs' specs to support the feature.
Preview | Diff