This repository was archived by the owner on Dec 1, 2025. It is now read-only.
Small updates to aggregate error reporting explainer#178
Open
alexmturner wants to merge 4 commits into
Open
Conversation
alexmturner
force-pushed
the
pending-report-limit
branch
from
d35de63 to
e9c1e39
Compare
alexmturner
changed the title
Adjusts pending report limit error handling: previously, the description implied that the pending report limit error would only be triggered when there is no space for the report. To avoid such reports always being dropped (or needing to add special case exemptions), we modify the trigger to occur when the limit is just reached. Adjusts insufficient budget condition to handle the situation where some (but not all) of a report's contributions are dropped due to insufficient budget. This could not occur before this feature. Explains the two-phase processing: to avoid complexity and self-referential loops, we process reports in two phases, meaning that errors are only triggered based on unconditional contributions.
alexmturner
force-pushed
the
pending-report-limit
branch
from
ac51492 to
d8c60a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts pending report limit error handling: previously, the description
implied that the pending report limit error would only be triggered when
there is no space for the report. To avoid such reports always being
dropped (or needing to add special case exemptions), we modify the
trigger to occur when the limit is just reached.
Adjusts insufficient budget condition to handle the situation where some
(but not all) of a report's contributions are dropped due to
insufficient budget. This could not occur before this feature.
Explains the two-phase processing: to avoid complexity and
self-referential loops, we process reports in two phases, meaning that
errors are only triggered based on unconditional contributions.