Open
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def check_password(self, password: str): | ||
| return self.pwd_hash == md5(password.encode('utf-8')).hexdigest() | ||
| return scrypt(password.encode('utf-8')).encode(hex=True) == self.pwd_hash |
Check failure
Code scanning / SonarCloud
Password hashing functions should use an unpredictable salt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 4 issues.
Fixed vulnerable JSON.stringify concatenation
Replaced the JSON.stringify concatenation with a constant format string to prevent potential log message tampering.(docker-compose.yml:1:24)[https://github.com/PatchWork AutoFix #4/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L1-L24]
Added 'security_opt' to the redis service to prevent privilege escalation and set 'read_only' to true.Fix weak password hashing using insecure MD5 algorithm
Updated password hashing to usehashlib.scryptinstead of insecure MD5 algorithm for enhanced security