Open
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def check_password(self, password: str): | ||
| return self.pwd_hash == md5(password.encode('utf-8')).hexdigest() | ||
| return self.pwd_hash == hashlib.scrypt(password.encode('utf-8'), salt=b'saltysalt', n=2**14, r=8, p=1).hex() |
Check failure
Code scanning / SonarCloud
Password hashing functions should use an unpredictable salt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 3 issues.
Fix: Set 'read_only: true' and 'no-new-privileges: true' in redis service
- Added 'read_only: true' to the 'redis' service to prevent malicious applications from modifying container files.Fix: Use parameterized query in Student.create
TheStudent.createmethod was vulnerable to SQL injection because it used string concatenation to build the SQL query. This commit fixes the vulnerability by using a parameterized query instead.Upgrade password hashing algorithm from MD5 to scrypt
Thecheck_passwordmethod has been updated to use thescryptalgorithm for password hashing instead ofmd5. Scrypt is considered more secure than MD5 and is more resistant to brute-force attacks.