Skip to content

fix: prevent mutating object when using pg transformer #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hariaakash wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: prevent mutating object when using pg transformer #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a9c12b
fix: prevent mutating object when using pg transformer
hariaakash Jan 7, 2023
77f8bc7
test: added test to check if mutation is prevented when pg format
hariaakash Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pg/format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ const escape = require('./escape');
* @returns { string }
*/
module.exports = function(statement, obj){
obj = JSON.parse(JSON.stringify(obj)); // clone obj to avoid mutations

const array_mode = Array.isArray(obj);
if(array_mode && obj.length === 0)
throw new Error('array should have at least one element');
Expand Down Expand Up @@ -46,4 +48,4 @@ module.exports = function(statement, obj){
values += (values.length > 0 ? ',' : '') + key + '=' + obj[key];
return statement.replace('?', values);
}
}
}
7 changes: 6 additions & 1 deletion pg/format.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,9 @@ tap.equal(format('INSERT INTO customer ?', { fullname: 'Test', balance: 1 }), `I
tap.equal(format('UPDATE customer SET ?', { last_seen: 'NOW()', visits: 3 }), `UPDATE customer SET last_seen=NOW(),visits=3`);
tap.equal(format('UPDATE customer SET ?', { fullname: 'Test', '!visits': '(SELECT COUNT(*) FROM customer_visits)' }), `UPDATE customer SET fullname='Test',visits=(SELECT COUNT(*) FROM customer_visits)`);

tap.equal(format('INSERT INTO customer ?', [{ fullname: 'Test', balance: 1 }, { fullname: 'Test 2', balance: 3 }]), `INSERT INTO customer (fullname,balance) VALUES ('Test',1),('Test 2',3)`);
tap.equal(format('INSERT INTO customer ?', [{ fullname: 'Test', balance: 1 }, { fullname: 'Test 2', balance: 3 }]), `INSERT INTO customer (fullname,balance) VALUES ('Test',1),('Test 2',3)`);

const input = [{a: 1, b: null}];
const backup = JSON.parse(JSON.stringify(input));
format('INSERT INTO customer ?', input);
tap.same(input, backup, 'format should not mutate its params');