Skip to content

This should never happen FIXME! solution for macOS#166

Open
YSaxon wants to merge 1 commit into
pauldreik:mainfrom
YSaxon:main
Open

This should never happen FIXME! solution for macOS#166
YSaxon wants to merge 1 commit into
pauldreik:mainfrom
YSaxon:main

Conversation

@YSaxon
Copy link
Copy Markdown

@YSaxon YSaxon commented Dec 12, 2024

I was getting these errors on macOS

Dirlist.cc::handlepossiblefile: This should never happen. FIXME! details on the next row:

I looked into them and discovered the root cause in my case was lack of Full Disk Access permissions given to my terminal app, so I added some code to both better explain the error in general in all cases, and suggest the solution in this particular macOS case (where opendir() is returning EPERM, when compiled for macOS)

@valerio-bozzolan
Copy link
Copy Markdown

valerio-bozzolan commented Dec 16, 2024

I appreciate the attempt to improve the error message but I don't agree on the solution since it assumes that the user is using the proprietary macOS operating system. Instead, if should just says that permissions are denied (e.g. in "normal" :D systems you may try to run "sudo" I guess).

Relevant discussion: #32

@YSaxon
Copy link
Copy Markdown
Author

YSaxon commented Dec 17, 2024 via email

@valerio-bozzolan
Copy link
Copy Markdown

Got it. Seems good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants