Added -rememberidentinode option which better handles hardlink groups#68
Open
bertbaron wants to merge 1 commit into
Open
Added -rememberidentinode option which better handles hardlink groups#68bertbaron wants to merge 1 commit into
bertbaron wants to merge 1 commit into
Conversation
Owner
|
Sorry for the late reply! Bonus points for providing a test script in the PR, well done! I will have to think a bit about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the option -rememberidentinode which better handles hardlink groups. I tried to keep the changes to the code at a minimum level and impact on performance of existing behavior neglectable. With the new option enabled hardlink groups are more or less handled as with -removeidentinode false while the performance is close to that of the default behavior.
This can make a big difference. These are some results from a test using the different options on three snapshots of some data taken with rsnapshot:
However, I had almost zero experience with C++ so I'm sure the code can be improved. Please let me know what you think.